-modulate in HCLp

[GreenKoopa]

-modulate works in HCL, but not in HCLp.

Searching the source I find 11 instances of HCLColorspace, but only 8 of HCLpColorspace. The instance missing in enhance.c is likely causing this issue.

Demonstration of the problem:

Code: Select all

convert hald:10 -colorspace Rec601Luma Luma.png
convert hald:10 -colorspace HCL  -channel G -evaluate Set 0 -colorspace sRGB HCL_set.png
convert hald:10 -colorspace HCLp -channel G -evaluate Set 0 -colorspace sRGB HCLp_set.png
convert hald:10 -define modulate:colorspace=HCL  -modulate 100,0,100 HCL_modulate.png
convert hald:10 -define modulate:colorspace=HCLp -modulate 100,0,100 HCLp_modulate.png

compare -metric PAE Luma.png HCL_set.png null:
compare -metric PAE Luma.png HCLp_set.png null:
compare -metric PAE Luma.png HCL_modulate.png null:
compare -metric PAE Luma.png HCLp_modulate.png null:

--- Output ---
1 (1.5259e-005)
1 (1.5259e-005)
1 (1.5259e-005)
25274 (0.385657)

[magick]

We can reproduce the problem you posted and have a patch in ImageMagick 6.8.6-7 Beta available by sometime tomorrow. Thanks.

[GreenKoopa]

I see the change in the source code
http://www.imagemagick.org/download/win ... indows.zip
but the behavior is the same in the new version
http://www.imagemagick.org/download/bin ... 64-dll.exe
The fix seemed easy, unless the source didn't make it into the new build?

[dlemstra]

I am having the same issue with the fix for this: viewtopic.php?f=3&t=20615. It looks like the recent changes did not make it into the windows build.

[GreenKoopa]

Appears fixed in the new 6.8.6-7 release. Thank you.