Legacy ImageMagick Discussions Archive

Should it not be initialized at zero?

Yes, I see. "ResetMagickMemory(&fits_info,0,sizeof(fits_info));"
Therefore this is harmless double assignment only.

One more :)

fits.c 310

(void) ResetMagickMemory(&fits_info,0,sizeof(fits_info));
fits_info.extend=MagickFalse;
fits_info.simple=MagickFalse;
fits_info.bits_per_pixel=8;
fits_info.columns=1;
fits_info.rows=1; // <==
fits_info.rows=1; // <==
fits_info.number_planes=1;
fits_info.min_data=0.0 ...

- typo
xml-tree.c 2564
char *XMLTreeTagToXML(XMLTreeInfo *xml_info,char **source,size_t *length, size_t *extent,size_t start,char ***attributes)

*source=(char *) ResizeQuantumMemory(*source,*extent,sizeof(*source)); // should be sizeof(**source ...

svg.c 282

if (svg_info->text != (char *) NULL)
svg_info->text=DestroyString(svg_info->text);

if (svg_info->scale != (double *) NULL)
svg_info->scale=(double *) (svg_info->scale); // <===

if (svg_info->title != (char *) NULL)
svg_info->title=DestroyString(svg_info->title);

quantum-import.c 151

PushDoublePixel()

quantum[7]=(*pixels++);
quantum[6]=(*pixels++);
quantum[5]=(*pixels++); // <===
quantum[5]=(*pixels++); // <===
quantum[3]=(*pixels++);
quantum[2]=(*pixels++);
quantum[1]=(*pixels++);
quantum[0]=(*pixels++);